Skip to content

feat(knowledge): add sourced dermatology resources - #91

Closed
Davidson3556 wants to merge 2 commits into
MoleCare:mainfrom
Davidson3556:issue-5-expand-knowledge
Closed

Davidson3556 wants to merge 2 commits into
MoleCare:mainfrom
Davidson3556:issue-5-expand-knowledge

Conversation

@Davidson3556

Copy link
Copy Markdown
Contributor

What does this change?

Adds four educational dermatology resources that MCP clients can read without credentials or network access:

  • molecare://knowledge/sun-protection explains SPF, UVA labelling, sunscreen use, shade and clothing
  • molecare://knowledge/common-benign-lesions describes several common non-cancerous growths while making clear that appearance alone cannot identify a lesion
  • molecare://knowledge/skin-self-examination provides a head-to-toe observation and recording routine
  • molecare://knowledge/dermatology-appointment explains how someone can prepare and what may happen during a routine skin appointment

Each resource includes a non-diagnostic scope boundary, the standard medical disclaimer, and dated source links from the NHS, American Academy of Dermatology, DermNet, American Family Physician, or an NHS hospital trust. The wording is paraphrased and stays educational: it does not classify a lesion, assign a risk level, or recommend an urgency.

The README and resource-list smoke tests now cover the expanded surface. A focused test also checks that every new resource is readable, names HTTPS sources, carries its disclaimer and boundary, and avoids diagnostic or triage language.

Related issue

Fixes #5

Checklist

  • npm run build passes
  • Server starts and all four resources can be listed and read in the mock-mode integration test
  • No new tools; tool schemas are unchanged
  • Works in mock mode (no credentials configured)
  • No secrets, real hostnames, account IDs, or personal data added
  • No patient images added, including in tests
  • Every new medical resource carries a non-diagnostic disclaimer

npm test: 82/82 passing.

Does this change a tool's response shape?

No tool response changes.

The resource surface changes additively: four new resource URIs are listed. Those new resources include a top-level sources array containing title, publisher, url, and accessed. Existing resource URIs and payloads are unchanged.

@YauhenBichel

Copy link
Copy Markdown
Member

Thank you for adding sources, this makes the content much easier to trust! One fix please: the UCLH "Skin biopsy" link is a neurology page (a skin biopsy for nerve tests), not about moles. Could you use the NHS page instead? https://www.nhs.uk/conditions/melanoma-skin-cancer/tests-and-next-steps-for-melanoma-skin-cancer/
Because this is health text, a clinician will also read it before we merge.

@YauhenBichel

Copy link
Copy Markdown
Member

Thank you, this is exactly right. The NHS page fits the biopsy line, and the other sources read well. I have no code changes to ask for. The last step is a clinician read of the wording, which I am arranging, and then we merge.

@YauhenBichel

Copy link
Copy Markdown
Member

Thank you for this, genuinely. The sourcing is careful, the NHS link you added is exactly right, and the code and tests are in good shape.

I am closing it for one reason only, and it is not about your work: this is health text that a clinician has to read and approve before it ships, and we do not have that review available at the moment. Holding your PR open for weeks while it waits would not be fair to you.

Nothing here is wasted. The branch stays, and when a clinician can review this properly I will come back to you and we can reopen it or pick it up together. If you would like something to work on in the meantime, the issues marked "good first issue" are free of this constraint, and I am happy to point you at one.

Thank you again for the care you put into it.

@Davidson3556

Copy link
Copy Markdown
Contributor Author

understood thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expand the dermatology knowledge resources

2 participants